pgsql: Improve ExecModifyTable comments.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve ExecModifyTable comments.
Date: 2017-08-03 16:51:54
Message-ID: E1ddJLm-0004YZ-1g@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve ExecModifyTable comments.

Some of these comments wrongly implied that only an AFTER ROW trigger
will cause a 'wholerow' attribute to be present for a foreign table,
but a BEFORE ROW trigger can have the same effect. Others implied
that it would always be present for a foreign table, but that's not
true either.

Etsuro Fujita and Robert Haas

Discussion: http://postgr.es/m/10026bc7-1403-ef85-9e43-c6100c1cc0e3@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/12a34f59bf8bc5babf375c95f5192d208dca1739

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-08-03 17:29:04 pgsql: Allow a foreign table CHECK constraint to be initially NOT VALID
Previous Message Robert Haas 2017-08-03 16:01:08 pgsql: Teach map_partition_varattnos to handle whole-row expressions.