pgsql: Teach map_partition_varattnos to handle whole-row expressions.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Teach map_partition_varattnos to handle whole-row expressions.
Date: 2017-08-03 16:01:08
Message-ID: E1ddIYe-0003Zf-Fb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teach map_partition_varattnos to handle whole-row expressions.

Otherwise, partitioned tables with RETURNING expressions or subject
to a WITH CHECK OPTION do not work properly.

Amit Langote, reviewed by Amit Khandekar and Etsuro Fujita. A few
comment changes by me.

Discussion: http://postgr.es/m/9a39df80-871e-6212-0684-f93c83be4097@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/610e8ebb0fadd7a738c2ad07fef6c5ea86b11f8d

Modified Files
--------------
src/backend/catalog/partition.c | 21 ++++++++----
src/backend/commands/tablecmds.c | 12 +++++--
src/backend/executor/nodeModifyTable.c | 4 +--
src/backend/parser/parse_utilcmd.c | 6 ++--
src/backend/rewrite/rewriteManip.c | 47 ++++++++++++++++++++++-----
src/include/catalog/partition.h | 3 +-
src/include/rewrite/rewriteManip.h | 2 +-
src/test/regress/expected/insert.out | 21 ++++++++++++
src/test/regress/expected/updatable_views.out | 26 +++++++++++++++
src/test/regress/sql/insert.sql | 13 ++++++++
src/test/regress/sql/updatable_views.sql | 27 +++++++++++++++
11 files changed, 157 insertions(+), 25 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-08-03 16:51:54 pgsql: Improve ExecModifyTable comments.
Previous Message Tom Lane 2017-08-03 04:15:52 Re: fixing pg_upgrade strings (was Re: pgsql: Add new files to nls.mk and add translation)