pgsql: Refactor to create generic WAL page read callback

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Refactor to create generic WAL page read callback
Date: 2016-01-21 01:20:24
Message-ID: E1aM3vE-0008I2-No@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Refactor to create generic WAL page read callback

Previously we didn’t have a generic WAL page read callback function,
surprisingly. Logical decoding has logical_read_local_xlog_page(), which was
actually generic, so move that to xlogfunc.c and rename to
read_local_xlog_page().
Maintain logical_read_local_xlog_page() so existing callers still work.

As requested by Michael Paquier, Alvaro Herrera and Andres Freund

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/422a55a68784fd00f4514834f3649140a9166fa5

Modified Files
--------------
src/backend/access/transam/xlogutils.c | 166 ++++++++++++++++++++++++
src/backend/replication/logical/logicalfuncs.c | 158 +---------------------
src/include/access/xlogutils.h | 3 +
3 files changed, 172 insertions(+), 155 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-01-21 02:31:13 pgsql: psql: Add tab completion for COPY with query
Previous Message Peter Geoghegan 2016-01-21 00:10:46 Re: pgsql: Support parallel joins, and make related improvements.

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2016-01-21 01:32:52 Re: Combining Aggregates
Previous Message Craig Ringer 2016-01-21 01:04:31 Re: Re: pglogical_output - a general purpose logical decoding output plugin