pgsql: Use materialize SRF mode in brin_page_items

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Use materialize SRF mode in brin_page_items
Date: 2015-08-13 16:02:37
Message-ID: E1ZPuxh-0005IF-GN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use materialize SRF mode in brin_page_items

This function was using the single-value-per-call mechanism, but the
code relied on a relcache entry that wasn't kept open across calls.
This manifested as weird errors in buildfarm during the short time that
the "brin-1" isolation test lived.

Backpatch to 9.5, where it was introduced.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/1136971daef209a40eb495b4bd74ce50fbd0fe63

Modified Files
--------------
contrib/pageinspect/brinfuncs.c | 223 ++++++++++++++++++---------------------
1 file changed, 101 insertions(+), 122 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-08-13 16:03:38 Re: Re: [COMMITTERS] Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Previous Message Stephen Frost 2015-08-13 15:06:35 Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.