Re: Re: [COMMITTERS] Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)
Date: 2015-08-13 16:03:38
Message-ID: 20150813160338.GA5232@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Tom Lane wrote:

> > (If I were tasked with fixing it, I'd be tempted to rewrite it to do
> > all the work in one call and return a tuplestore; the alternative
> > seems to be to try to keep the index open across multiple calls,
> > which would be a mess.)
>
> Here's a patch doing that.

Pushed, thanks.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-08-13 17:25:41 pgsql: Improve regression test case to avoid depending on system catalo
Previous Message Alvaro Herrera 2015-08-13 16:02:37 pgsql: Use materialize SRF mode in brin_page_items

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-08-13 16:03:49 Re: TAP tests are badly named
Previous Message Michael Paquier 2015-08-13 15:54:43 Re: In-core regression tests for replication, cascading, archiving, PITR, etc.