pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding
Date: 2013-06-08 14:25:57
Message-ID: E1UlK5d-0006GZ-Sz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Don't downcase non-ascii identifier chars in multi-byte encodings.

Long-standing code has called tolower() on identifier character bytes
with the high bit set. This is clearly an error and produces junk output
when the encoding is multi-byte. This patch therefore restricts this
activity to cases where there is a character with the high bit set AND
the encoding is single-byte.

There have been numerous gripes about this, most recently from Martin
Schäfer.

Backpatch to all live releases.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d535136b5d60b19f7ffa777b97ed301739c15a9d

Modified Files
--------------
src/backend/parser/scansup.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2013-06-09 00:09:15 Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding
Previous Message Andrew Dunstan 2013-06-08 14:25:39 pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2013-06-08 14:30:32 Re: Optimising Foreign Key checks
Previous Message Pavan Deolasee 2013-06-08 08:06:46 Re: Possible bug in cascaded standby