| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding |
| Date: | 2013-06-09 00:09:15 |
| Message-ID: | CA+TgmoYmM4him2vWioQCKziYy5BaCz1RszAbGk3VX=dScB1=mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Jun 8, 2013 at 10:25 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Don't downcase non-ascii identifier chars in multi-byte encodings.
>
> Long-standing code has called tolower() on identifier character bytes
> with the high bit set. This is clearly an error and produces junk output
> when the encoding is multi-byte. This patch therefore restricts this
> activity to cases where there is a character with the high bit set AND
> the encoding is single-byte.
>
> There have been numerous gripes about this, most recently from Martin
> Schäfer.
>
> Backpatch to all live releases.
I'm all for changing this, but back-patching seems like a terrible
idea. This could easily break queries that are working now.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2013-06-09 02:52:54 | Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding |
| Previous Message | Andrew Dunstan | 2013-06-08 14:25:57 | pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-06-09 00:20:42 | Re: Optimising Foreign Key checks |
| Previous Message | MauMau | 2013-06-08 23:42:24 | Re: Hard limit on WAL space used (because PANIC sucks) |