pgsql: For testing purposes, reinsert a timeout in pgstat.c's wait call

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: For testing purposes, reinsert a timeout in pgstat.c's wait call
Date: 2012-05-14 19:03:21
Message-ID: E1SU0YD-0006Y4-Vo@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

For testing purposes, reinsert a timeout in pgstat.c's wait call.

Test results from buildfarm members mastodon/narwhal (Windows Server 2003)
make it look like that platform just plain loses FD_READ events
occasionally, and the only reason our previous coding seemed to work was
that it timed out every couple of seconds and retried the whole operation.
Try to verify this by reinserting a finite timeout into the pgstat loop.
This isn't meant to be a permanent patch either, just to confirm or
disprove a theory.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d461d0502b6e20c6d4ec326ba2faec8212fd5dee

Modified Files
--------------
src/backend/postmaster/pgstat.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-05-14 19:05:21 Re: Re: [COMMITTERS] pgsql: Ensure age() returns a stable value rather than the latest value
Previous Message Tom Lane 2012-05-14 14:57:15 pgsql: Force pgwin32_recv into nonblock mode when called from pgstat.c.