| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Alberto Piai <alberto(dot)piai(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: tablecmds: fix bug where index rebuild loses replica identity on partitions |
| Date: | 2026-08-03 05:16:58 |
| Message-ID: | E0ACC025-644E-4BC3-A31A-2D68AA3A728B@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jul 31, 2026, at 19:22, Alberto Piai <alberto(dot)piai(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Wed Jul 29, 2026 at 7:07 PM CEST, Sami Imseih wrote:
>> Attached is a v12 with these minor fixes. I also improved the commit
>> message for 0002.
>
> A small comment on v12 0001: the patch adds a parameter to
> generateClonedIndexStmt() to pass the index name. Is there a reason for
> setting the index name in the function, rather than setting it in
> DefineIndex() directly on the newly generated statement?
>
Good point. I think you are right. We don’t need to touch generateClonedIndexStmt(), we can just set the index name directly in DefineIndex() when needed.
PFA v13: addressed Alberto’s comment on 0001; 0002 is the same as v12.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-tablecmds-preserve-partition-index-names-during-.patch | application/octet-stream | 14.5 KB |
| v13-0002-tablecmds-preserve-replica-identity-and-cluster-.patch | application/octet-stream | 28.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-08-03 05:27:55 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Previous Message | Ayush Tiwari | 2026-08-03 05:13:28 | Re: Add a pg_wal_preallocate() SQL function to eagerly create future WAL segments |