| From: | "Alberto Piai" <alberto(dot)piai(at)gmail(dot)com> |
|---|---|
| To: | "Sami Imseih" <samimseih(at)gmail(dot)com>, "Chao Li" <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | "Alberto Piai" <alberto(dot)piai(at)gmail(dot)com>, "Postgres hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Xuneng Zhou" <xunengzhou(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz> |
| Subject: | Re: tablecmds: fix bug where index rebuild loses replica identity on partitions |
| Date: | 2026-07-31 11:22:21 |
| Message-ID: | DKCPUB41DLIW.VLVF35HFDNRD@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed Jul 29, 2026 at 7:07 PM CEST, Sami Imseih wrote:
> Attached is a v12 with these minor fixes. I also improved the commit
> message for 0002.
A small comment on v12 0001: the patch adds a parameter to
generateClonedIndexStmt() to pass the index name. Is there a reason for
setting the index name in the function, rather than setting it in
DefineIndex() directly on the newly generated statement?
The approach and the patches look otherwise good to me.
Regards,
Alberto
--
Alberto Piai
Sensational AG
Zürich, Switzerland
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-07-31 11:22:59 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | Alberto Piai | 2026-07-31 11:21:32 | Re: tablecmds: fix bug where index rebuild loses replica identity on partitions |