Re: Increase repalloc_array() usage in buffile.c

On Thu Jul 30, 2026 at 6:42 PM CDT, Michael Paquier wrote:
> On Wed, Jul 29, 2026 at 03:21:28PM -0500, Sami Imseih wrote:
>> hmm, right. specifically 1b105f9472bdb bulk updated buffile.c. Only explanation
>> I see is they were missed in a large update.
>
> If you are interested in more work in this area, I think that we still
> have a couple of holes in contrib/, and even more in the backend code.
> Perhaps a LLM scan would help.
>
> The reason why these holes exist is that the patch series of
> 1b105f9472bdb was quite large, so I have been focusing mainly on
> making sure that all the suggested changes were right instead of
> trying to fix all of them. The long term picture is that we should do
> the switch to do more type enforcements, and that this work is
> incremental.
>
> Saying all that, the proposed patch makes sense, and this is
> incremental work, so I am going to apply it.
>
> Thanks for caring. :)

Let me see what I can come up with. As a committer, how would you like
the patches? I could do file by file, subsystem by subsystem, or just
one large single patch? I don't mind putting in the work to translate
all realloc calls where it makes sense, but I would like to make sure
I organize it in such a way to minimize work for you.

--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)