| From: | "Tristan Partin" <tristan(at)partin(dot)io> |
|---|---|
| To: | "Mark Wong" <markwkm(at)gmail(dot)com> |
| Cc: | <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: updates for handling optional argument in system functions |
| Date: | 2026-06-18 16:50:13 |
| Message-ID: | DJCBVXBWYQ55.2V718KGAFOW81@partin.io |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu Jun 11, 2026 at 2:47 PM UTC, Mark Wong wrote:
> On Fri, Jun 05, 2026 at 09:04:34PM +0000, Tristan Partin wrote:
>> > Patch 1
>> >
>> > - proargtypes => 'oid bool', prosrc => 'pg_get_ruledef_ext' },
>> > + proargtypes => 'oid bool', proargnames => '{rule,pretty}',
>> > + proargdefaults => '{false}',prosrc => 'pg_get_ruledef' },
>>
>> There is a space missing before prosrc in the added line.
>>
>> Other than that one comment, this looks good to me.
>
> Oops, v8.1 attached to correct that white space.
Patches look great Mark!
--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-06-18 16:52:35 | Re: Performance Degradation (Table becomes bloat) During Repeated Bulk UPDATE Operations |
| Previous Message | Khoa Nguyen | 2026-06-18 16:36:34 | Re: [PATCH] vacuumdb: Add --exclude-database option |