| From: | Khoa Nguyen <kdnguyen9(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Ben Mejia <benjamin(dot)arthur(dot)mejia(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Mohamed ALi <moali(dot)pg(at)gmail(dot)com> |
| Subject: | Re: [PATCH] vacuumdb: Add --exclude-database option |
| Date: | 2026-06-18 16:36:34 |
| Message-ID: | CAONt3B2KHi-TbtZUKjvHh3URn+91EApWXKEjMdCXFMV3dLJvVg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 17, 2026 at 7:24 PM Ben Mejia
<benjamin(dot)arthur(dot)mejia(at)gmail(dot)com> wrote:
>
> I think that the behavior of this patch that silently ignores --exlcude-database "non-existent-db" is broken. What if someone has a large database "my-db-name", and they misspell it:
>
> $ vacuumdb --all --exclude-database "my-dbname"
>
> This will kick off a vacuum including the "my-db-name" they were trying to exclude.
>
> I think it would be better to generate an error and not do anything in this case.
+1
Since exclude-schema validates and stops on error, I think it would
make sense to do the same for exclude-database. Current users are
used to this behavior so it's best to keep it consistent.
>
> This also tracks with vacuumdb's existing behavior on --table/--schema which will tell you about a typo.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-06-18 16:50:13 | Re: updates for handling optional argument in system functions |
| Previous Message | Nathan Bossart | 2026-06-18 16:30:41 | Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c |