Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.

From: "Matheus Alcantara" <matheusssilv97(at)gmail(dot)com>
To: "Alexander Korotkov" <aekorotkov(at)gmail(dot)com>
Cc: "Dmitry Koval" <d(dot)koval(at)postgrespro(dot)ru>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
Date: 2026-04-22 10:53:04
Message-ID: DHZMLEQ2VMIO.2F3VN1UMHHQ8G@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue Apr 21, 2026 at 4:35 PM -03, Alexander Korotkov wrote:
>> > I've revised the patch.
>> > 1) collectPartitionIndexExtDeps() is rewritten(). Now it works in
>> > three phases: collect, sort, compare. The comparison phase requires
>> > strict equivalence of dependencies and doesn't depend on the order.
>> > The complexity is now O(n * log(n)), which I think is acceptable.
>> > 2) PartitionIndexExtDepEntry struct now have indexOid. So, on
>> > conflict error contains both partition index names.
>> > 3) Tests moved to
>> > src/test/modules/test_extensions/sql/test_extdepend.sql where
>> > test_ext3/test_ext5 extensions are available.
>> > 4) More tests for different scenarios.
>> >
>> > Could you, please, review this changes?
>> >
>>
>> I think that you miss to include the patch?
>
> Yep, here it is.
>

Thanks for the patch. It looks good to me, and I confirm that it fix the
issues that I miss on the previous version.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matheus Alcantara 2026-04-22 10:58:06 Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
Previous Message Kirill Reshke 2026-04-22 10:48:18 Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.