Re: Leftover member in openssl part of Port struct

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Leftover member in openssl part of Port struct
Date: 2016-08-31 14:02:09
Message-ID: DE3CE48B-CEDA-4A9E-A09E-4A3F63D0A4A0@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On 31 Aug 2016, at 15:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> When SSL renegotiation was removed in 426746b9 the only consumer of the openssl
>> specific count member in the Port struct was removed, but the member was left
>> together with a few updates to it which are unused. Attached patch removes the
>> leftovers which now serves no purpose unless I’m missing something.
>
> Hm, well, we can't remove those case labels as control would then end
> up in the default case which throws an error.

Doh, I’ll go stand in the corner.

> But otherwise this seems
> sound. Without renegotiation the count is not very useful anyway
> since it's likely to overflow (at least if long is 32 bits).

Yeah. Thanks for applying.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-08-31 14:10:34 Re: pg_sequence catalog
Previous Message Tom Lane 2016-08-31 14:01:50 Re: pg_sequence catalog