Re: Leftover member in openssl part of Port struct

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Leftover member in openssl part of Port struct
Date: 2016-08-31 13:12:40
Message-ID: 28257.1472649160@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> When SSL renegotiation was removed in 426746b9 the only consumer of the openssl
> specific count member in the Port struct was removed, but the member was left
> together with a few updates to it which are unused. Attached patch removes the
> leftovers which now serves no purpose unless Im missing something.

Hm, well, we can't remove those case labels as control would then end
up in the default case which throws an error. But otherwise this seems
sound. Without renegotiation the count is not very useful anyway
since it's likely to overflow (at least if long is 32 bits).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2016-08-31 13:13:43 Re: Exclude schema during pg_restore
Previous Message Joel Jacobson 2016-08-31 13:09:21 Re: autonomous transactions