| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Empty ul on navmenu |
| Date: | 2017-02-28 15:45:06 |
| Message-ID: | DD6F8622-516F-4E62-AF2A-7F16E7CB9283@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
When the navmenu is empty in base/page.html, the sidebar renders an empty list
<ul></ul> which is illegal HTML. One example (the only?) is on account/login/.
Fix by checking length of passed list as in attached.
This removes the one gray line in the sidebar which could be seen as perhaps
making the page look a bit (more) lopsided, but thats a separate issue.
Personally I don’t think an empty gray box looks better, but if we want that it
could be fixed with <div> that renders and shows the gray background.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| empty_navmenu.patch | application/octet-stream | 967 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-01 15:44:59 | Re: [pgsql-www] Small issue in online devel documentation build |
| Previous Message | Magnus Hagander | 2017-02-28 14:21:57 | Re: A few more http links |