Re: Empty ul on navmenu

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: Empty ul on navmenu
Date: 2017-03-08 03:39:13
Message-ID: CABUevEyFXyLEURhweYccvNDeN7qt8o2AsRsXnopgZeNVbE49cQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Tue, Feb 28, 2017 at 7:45 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> When the navmenu is empty in base/page.html, the sidebar renders an empty
> list
> <ul></ul> which is illegal HTML. One example (the only?) is on
> account/login/.
> Fix by checking length of passed list as in attached.
>
> This removes the one gray line in the sidebar which could be seen as
> perhaps
> making the page look a bit (more) lopsided, but thats a separate issue.
> Personally I don’t think an empty gray box looks better, but if we want
> that it
> could be fixed with <div> that renders and shows the gray background.
>

Thanks, applied.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2017-03-08 03:42:13 Re: Cannot receive reset password email
Previous Message Arulappan, Arul Shaji 2017-03-08 01:26:07 Re: Wiki editor request