Re: testclient.exe installed under MSVC

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Jacob Champion <pchampion(at)vmware(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: testclient.exe installed under MSVC
Date: 2022-05-02 13:14:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 1 May 2022, at 15:23, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sun, May 01, 2022 at 01:07:06AM -0700, Noah Misch wrote:
>> My annual audit for executables missing Windows icons turned up these:
>> pginstall/bin/testclient.exe
>> pginstall/bin/uri-regress.exe
>> I was going to add the icons, but I felt the testclient.exe name is too
>> generic-sounding to be installed. testclient originated in commit ebc8b7d. I
>> recommend ceasing to install both programs under MSVC. (The GNU make build
>> system does not install them.)
> But MSVC works differently. does a TempInstall(), which
> is a simple Install(), so isn't it going to be an issue for the tests
> if these two tools are not installed anymore?
>> If that's unwanted for some reason, could you
>> rename testclient to something like libpq_test?
> Yes, the renaming makes sense. I'd say to do more, and also rename
> uri-regress, removing the hyphen from the binary name and prefix both
> binaries with a "pg_".

Renaming is probably the best option given how MSVC works. Using a pg_ prefix
makes them sound like actual useful tools though with (albeit small) risk for
confusion? Noah's suggestion of libpq_ is perhaps better: libpq_testclient.

Daniel Gustafsson

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-05-02 13:24:30 configure openldap crash warning
Previous Message Julien Rouhaud 2022-05-02 13:14:19 Re: Unfiltered server logs routing via a new elog hook or existing emit_log_hook bypassing log_min_message check