| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Osama Abdul Qader <osamaabdulqader(dot)cs(at)gmail(dot)com> |
| Subject: | Re: Fix detection of truncated zstd-compressed backups |
| Date: | 2026-08-13 20:57:29 |
| Message-ID: | D8E3F994-FA42-4483-9905-D612DEFE7763@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 13 Aug 2026, at 07:11, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> PFA v7: addressed Jipan’s comment.
Sorry for being slow on this, things are quite busy but I hope to have a review
soon. While poking at this I realized that our compression code in pg_dump
likely has the same issue. I hacked up a quick PoC diff (attached) but it's
untested (can one actually test the data-in-zstd-internal-buffers case at all?)
and mainly a sketch. If you want to pick it up and rework into this patchset
to tackle it treewide then that would be fantastic.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump.diff.txt | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-08-13 21:40:17 | Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS? |
| Previous Message | Bharath Rupireddy | 2026-08-13 20:50:00 | Re: [PATCH] Refactor remaining zero-fill relation extensions to use smgrzeroextend() |