| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Osama Abdul Qader <osamaabdulqader(dot)cs(at)gmail(dot)com> |
| Subject: | Re: Fix detection of truncated zstd-compressed backups |
| Date: | 2026-08-13 22:59:19 |
| Message-ID: | 4D9CE522-B95D-4C3B-A81C-C57ABBF6CF6A@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Aug 14, 2026, at 04:57, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 13 Aug 2026, at 07:11, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>> PFA v7: addressed Jipan’s comment.
>
> Sorry for being slow on this, things are quite busy but I hope to have a review
> soon. While poking at this I realized that our compression code in pg_dump
> likely has the same issue. I hacked up a quick PoC diff (attached) but it's
> untested (can one actually test the data-in-zstd-internal-buffers case at all?)
> and mainly a sketch. If you want to pick it up and rework into this patchset
> to tackle it treewide then that would be fantastic.
>
> --
> Daniel Gustafsson
>
> <pg_dump.diff.txt>
I can work on this today.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-08-13 23:30:00 | Re: Report index currently being vacuumed in pg_stat_progress_vacuum |
| Previous Message | Dhruv Aron | 2026-08-13 22:49:20 | Re: Restructured Shared Buffer Hash Table |