From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Reorder connection markers in libpq TAP tests |
Date: | 2023-04-21 10:55:44 |
Message-ID: | D7B57DAB-8FC0-48EA-A499-C59E299B4EB8@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 21 Apr 2023, at 08:38, Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
>
> On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
>>
>> Commit 7f5b198 introduced TAP tests that use string literals to mark
>> the presence of a query in server logs. For no explicable reason, the
>> tests with the marker 'connect2' occur before the tests that use
>> 'connect1' marker.
>>
>> The attached patch swaps the connection marker strings so that a
>> reader doesn't have to spend extra deciphering why 'connect2' tests
>> appear before 'connect1' tests.
>
> Please see attached v2 of the patch. It now includes same fix in
> another TAP tests file.
- 'Potentially unsafe test load_balance not enabled in PG_TEST_EXTRA';
+ 'Potentially unsafe test; load_balance not enabled in PG_TEST_EXTRA';
We have this spelling without a ';' in multiple places so I left this alone.
I have applied this version of the patch apart from the above hunk. Thanks!
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Anton Voloshin | 2023-04-21 10:58:34 | Re: duplicate function declaration in multirangetypes_selfuncs.c |
Previous Message | Pavel Borisov | 2023-04-21 10:45:16 | Re: duplicate function declaration in multirangetypes_selfuncs.c |