| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reorder connection markers in libpq TAP tests |
| Date: | 2023-04-21 06:38:25 |
| Message-ID: | CABwTF4USR+RmEx1ef1H=y8x3gJrgSv7+pXubQbsZuyvQ+TBgKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
>
> Commit 7f5b198 introduced TAP tests that use string literals to mark
> the presence of a query in server logs. For no explicable reason, the
> tests with the marker 'connect2' occur before the tests that use
> 'connect1' marker.
>
> The attached patch swaps the connection marker strings so that a
> reader doesn't have to spend extra deciphering why 'connect2' tests
> appear before 'connect1' tests.
Please see attached v2 of the patch. It now includes same fix in
another TAP tests file.
Best regards,
Gurjeet https://Gurje.et
Postgres Contributors Team, http://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Reorder-connection-markers-in-TAP-tests.patch | application/x-patch | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2023-04-21 06:39:10 | Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns |
| Previous Message | Gurjeet Singh | 2023-04-21 06:00:00 | Reorder connection markers in libpq TAP tests |