Re: [PATCH] Implement INSERT SET syntax

From: Gareth Palmer <gareth(at)internetnz(dot)net(dot)nz>
To: Marko Tiikkaja <marko(at)joh(dot)to>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Implement INSERT SET syntax
Date: 2019-07-17 23:30:04
Message-ID: D50A93EB-11F3-4ED2-8192-0328DF901BBA@internetnz.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Marko,

> On 17/07/2019, at 5:52 PM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
>
> On Wed, Jul 17, 2019 at 7:30 AM Gareth Palmer <gareth(at)internetnz(dot)net(dot)nz> wrote:
> Attached is a patch that adds the option of using SET clause to specify
> the columns and values in an INSERT statement in the same manner as that
> of an UPDATE statement.
>
> Cool! Thanks for working on this, I'd love to see the syntax in PG.
>
> There was a brief discussion regarding INSERT SET on pgsql-hackers in late
> August 2009 [1].
>
> There was also at least one slightly more recent adventure: https://www.postgresql.org/message-id/709e06c0-59c9-ccec-d216-21e38cb5ed61%40joh.to
>
> You might want to check that thread too, in case any of the criticism there applies to this patch as well.

Thank-you for the pointer to that thread.

I think my version avoids issue raised there by doing the conversion of the SET clause as part of the INSERT grammar rules.

Gareth

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-07-17 23:36:11 Re: Custom table AMs need to include heapam.h because of BulkInsertState
Previous Message David Rowley 2019-07-17 23:29:37 Re: Custom table AMs need to include heapam.h because of BulkInsertState