Re: Custom table AMs need to include heapam.h because of BulkInsertState

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Custom table AMs need to include heapam.h because of BulkInsertState
Date: 2019-07-17 23:29:37
Message-ID: CAKJS1f91gBX9EcZN+GTW-BRv4zpE0DryXz7569R9eLzR+17n+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 17 Jul 2019 at 06:46, Andres Freund <andres(at)anarazel(dot)de> wrote:
> 1) Have ExecFindPartition() return via a bool* whether the partition is
> being accessed for the first time. In copy.c push the partition onto
> a list of to-be-bulk-finished tables.
> 2) Add a execPartition.c function that returns all the used tables from
> a PartitionTupleRouting*.

#2 seems better than #1 as it does not add overhead to ExecFindPartition().

Are you thinking this should go back into v12, or just for v13 only?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gareth Palmer 2019-07-17 23:30:04 Re: [PATCH] Implement INSERT SET syntax
Previous Message Tom Lane 2019-07-17 23:20:04 Re: Parallel Append subplan order instability on aye-aye