| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding |
| Date: | 2021-01-11 06:22:05 |
| Message-ID: | D1AB20AC-1B51-4296-87DB-9247038B2F4D@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 10 янв. 2021 г., в 14:43, Noah Misch <noah(at)leadboat(dot)com> написал(а):
>
>> Can you please send revised patches with fixes?
>
> Attached.
> <slru-truncate-modulo-v6.patch>
> <slru-truncate-t-insurance-v5.patch>
I'm marking patch as ready for committer.
I can't tell should we backpatch insurance patch or not: it potentially fixes unknown bugs, and potentially contains unknown bugs. I can't reason because of such uncertainty. I've tried to look for any potential problem and as for now I see none. Chances are <slru-truncate-t-insurance-v5.patch> is doing code less error-prone.
Fix <slru-truncate-modulo-v6.patch> certainly worth backpatching.
Thanks!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-01-11 06:41:54 | Re: [HACKERS] Custom compression methods |
| Previous Message | Bharath Rupireddy | 2021-01-11 06:15:47 | Re: Added schema level support for publication. |