Re: Support to define custom wait events for extensions

From: "Tristan Partin" <tristan(at)neon(dot)tech>
To: "Masahiro Ikeda" <ikedamsh(at)oss(dot)nttdata(dot)com>, <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support to define custom wait events for extensions
Date: 2023-07-11 17:39:52
Message-ID: CTZIZDTI9J08.1WLW5E0FWL7LV@gonk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> From bf06b8100cb747031959fe81a2d19baabc4838cf Mon Sep 17 00:00:00 2001
> From: Masahiro Ikeda <masahiro(dot)ikeda(dot)us(at)hco(dot)ntt(dot)co(dot)jp>
> Date: Fri, 16 Jun 2023 11:53:29 +0900
> Subject: [PATCH 1/2] Support custom wait events for extensions.

> + * This is indexed by event ID minus NUM_BUILTIN_WAIT_EVENT_EXTENSION, and
> + * stores the names of all dynamically-created event ID known to the current
> + * process. Any unused entries in the array will contain NULL.

The second ID should be plural.

> + /* If necessary, create or enlarge array. */
> + if (eventId >= ExtensionWaitEventTrancheNamesAllocated)
> + {
> + int newalloc;
> +
> + newalloc = pg_nextpower2_32(Max(8, eventId + 1));

Given the context of our last conversation, I assume this code was
copied from somewhere else. Since this is new code, I think it would
make more sense if newalloc was a uint16 or size_t.

From what I undersatnd, Neon differs from upstream in some way related
to this patch. I am trying to ascertain how that is. I hope to provide
more feedback when I learn more about it.

Tristan Partin
Neon (

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2023-07-11 17:50:28 Re: [PoC] Federated Authn/z with OAUTHBEARER
Previous Message Alvaro Herrera 2023-07-11 17:29:04 Re: cataloguing NOT NULL constraints