| From: | "Tristan Partin" <tristan(at)neon(dot)tech> |
|---|---|
| To: | "Tristan Partin" <tristan(at)neon(dot)tech>, "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | "Peter Geoghegan" <pg(at)bowt(dot)ie> |
| Subject: | Re: abi-compliance-checker |
| Date: | 2023-06-12 15:23:55 |
| Message-ID: | CTARXHXB8UW7.2PQEWYP1PSSN5@gonk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon Jun 12, 2023 at 10:10 AM CDT, Tristan Partin wrote:
> On Sat Jun 10, 2023 at 9:17 AM CDT, Peter Eisentraut wrote:
> > I have rearranged this a bit. There are now two build options, called
> > abidw and abidiff. The abidw option produces the xml file, that you
> > would then at appropriate times commit into the tree as the base. The
> > abidiff option enables the abidiff tests. This doesn't actually require
> > abidw, since abidiff can compare the binary directly against the
> > recorded XML file. So these options are distinct and nonoverlapping.
> >
> > Note that in this setup, you still need a conditional around the abidiff
> > test() call, because otherwise meson setup will fail if the base file
> > doesn't exist (yet), so it would be impossible to bootstrap this system.
>
> Could you speak more to the workflow you see with managing the checked
> in diff files?
Just saw your other email which talks about the workflow.
--
Tristan Partin
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-06-12 15:37:07 | Re: Add support for AT LOCAL |
| Previous Message | Tristan Partin | 2023-06-12 15:10:23 | Re: abi-compliance-checker |