Re: Pluggable Storage - Andres's take

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Pluggable Storage - Andres's take
Date: 2018-10-21 21:18:15
Message-ID: CAPpHfdv62w7TSO8tGGB352wsqv43Gg2FzEiX6uyGne3bbHF3nQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Oct 18, 2018 at 6:28 AM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> On Tue, Oct 16, 2018 at 6:06 AM Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>> * 0002-add-costing-function-to-API.patch – adds function for costing
>> sequential and table sample scan to tableam API. zheap costing
>> function are now copies of heap costing function. This should be
>> adjusted in future.
>
> This patch misses the new *_cost.c files that are added specific cost
> functions.

Thank you for noticing. Revised patchset is attached.

>> Estimation for heap lookup during index scans
>> should be also pluggable, but not yet implemented (TODO).
>
> Yes, Is it possible to use the same API that is added by above
> patch?

I'm not yet sure. I'll elaborate more on that. I'd like to keep
number of costing functions small. Handling of costing of index scan
heap fetches will probably require function signature change.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0001-remove-extra-snapshot-functions-2.patch application/octet-stream 4.4 KB
0002-add-costing-function-to-API-2.patch application/octet-stream 27.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-10-21 23:20:45 Re: Patch to avoid SIGQUIT accident
Previous Message Heikki Linnakangas 2018-10-21 21:06:02 Re: [PATCH] XLogReadRecord returns pointer to currently read page