Re: Fix for gistchoose

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for gistchoose
Date: 2012-08-30 17:49:18
Message-ID: CAPpHfdv12be==ckYJ=7a+D6RuGqRC=D2k0MeqF-JxxEAwBRsFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 30, 2012 at 9:11 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov
> <aekorotkov(at)gmail(dot)com> wrote:
> > I found that code of gistchoose doesn't follow it's logic. Idea of
> > gistchoose is that first column penalty is more important than penalty of
> > second column. If we meet same penalty values of first column then we
> choose
> > minimal penalty value of second column among them.
>
> Nice catch. Thanks for the patch, which I have now committed. But
> since these functions were very short on useful comments, I added
> some. Hopefully they're even right, but let me know if you think
> otherwise, or have any ideas for further improvement.

Thanks! Comments looks good for me.

------
With best regards,
Alexander Korotkov.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-08-30 17:50:50 Re: patch: shared session variables
Previous Message Robert Haas 2012-08-30 17:42:55 Re: splitting *_desc routines