| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for gistchoose |
| Date: | 2012-08-30 17:11:12 |
| Message-ID: | CA+TgmobtX7Fzz9jB3YfaAQihvW8fGL+YLz0ZfM=48cQxUAAJUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov
<aekorotkov(at)gmail(dot)com> wrote:
> I found that code of gistchoose doesn't follow it's logic. Idea of
> gistchoose is that first column penalty is more important than penalty of
> second column. If we meet same penalty values of first column then we choose
> minimal penalty value of second column among them.
Nice catch. Thanks for the patch, which I have now committed. But
since these functions were very short on useful comments, I added
some. Hopefully they're even right, but let me know if you think
otherwise, or have any ideas for further improvement.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-08-30 17:19:10 | Re: Don't allow relative path for copy from file |
| Previous Message | Joe Abbate | 2012-08-30 16:59:14 | Re: pg_operator.oprcode in 9.2rc1 |