Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Paul Kim <mok03127(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum
Date: 2026-07-20 11:59:05
Message-ID: CAPpHfduJUVWWP707tfxuV6vDwFe-wWyDE6+dxnrbp6VtwbgnWA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 20, 2026 at 1:45 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> > On 19 Jul 2026, at 19:27, Paul Kim <mok03127(at)gmail(dot)com> wrote:
> >
> > no CHECK_FOR_INTERRUPTS()
>
> As far as I remember, we hold a cleanup lock on posting tree root.
> We cannot process interrupts while holding a LWLock.
>
> I'm afraid to fix this problem we need a real page deletion with
> full fledged concurrency protocol as we do it in B-tree or GiST.
>
> I've written a patch for this in 2018. I hope to return to this one day.

We're holding cleanup lock on posting tree root while
ginScanPostingTreeToDelete(), not ginVacuumPostingTreeLeaves(). So, I
think yes, vacuum_delay_point() was deleted unintentionally. I'm
going to get closer look on this in the next couple of days.

------
Regards,
Alexander Korotkov
Supabase

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2026-07-20 12:00:48 Re: Fix LSN format in REPACK worker debug message
Previous Message Jim Jones 2026-07-20 11:52:23 Re: COMMENTS are not being copied in CREATE TABLE LIKE