| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | ZizhuanLiu X-MAN <44973863(at)qq(dot)com>, matheusssilv97 <matheusssilv97(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, "masao(dot)fujii" <masao(dot)fujii(at)gmail(dot)com>, "david(dot)g(dot)johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, tgl <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "huseyin(dot)d3r" <huseyin(dot)d3r(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: COMMENTS are not being copied in CREATE TABLE LIKE |
| Date: | 2026-07-20 11:52:23 |
| Message-ID: | 2d41978b-3bca-4756-b0a0-b6e707ad7793@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi ZizhuanLiu
Thanks for the detailed review!
On 18.07.26 16:03, ZizhuanLiu X-MAN wrote:
> 3. In cases where multiple source tables are referenced in one `LIKE` clause, I suggest skipping table
> comment copying entirely. Concatenating multiple disparate table comments would result in bloated
> and confusing text that fails to accurately describe the intended purpose of the combined new table.
I slightly disagree. I don't have a strong opinion about it, but I find
this a rather unnecessary limitation. I do understand the concern of a
bloated comment, but doing so we sort of imply that *all* table comments
are not fit for this feature, which is arguably not accurate. IMHO, if
the user explicitly wants the comments to be copied, we should not judge
if the they make sense or not -- of course, given that the documentation
describes the concatenation.
What do you think?
Thanks for the comments. Much appreciated!
Best, Jim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-07-20 11:59:05 | Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum |
| Previous Message | Matthias van de Meent | 2026-07-20 11:51:33 | Re: Unexpected behavior after OOM errors |