Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: sivasubr(at)amazon(dot)com
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages
Date: 2018-07-19 18:27:59
Message-ID: CAPpHfduDzRXEC7Y4dWN_BNqpKC6=vR9+sRLx2yUpvsO+3wePNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 19, 2018 at 6:17 PM R, Siva <sivasubr(at)amazon(dot)com> wrote:

> > On Thu, Jul 19, 2018 at 2:43 PM Alexander Korotkov <
> a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> > It appears that we need to handle empty posting list pages also
> in disassembleLeaf(). Updated patch is attached. I'm
> > going to commit it.
> Thank you so much for reviewing the patch! You are right, we need to
> handle the regular insert/vacuum path for the empty page as well, thanks
> for fixing that. The updated patch looks good to me.
>
> >BTW, what is your full name for the commit message?
> My full name is "Sivasubramanian Ramasubramanian".
> Email : sivasubr(at)amazon(dot)com

Pushed, thanks!

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-19 18:29:51 Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages
Previous Message Andrey Borodin 2018-07-19 18:26:05 Re: GiST VACUUM