| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Implement waiting for wal lsn replay: reloaded |
| Date: | 2025-08-08 06:54:18 |
| Message-ID: | CAPpHfdtVF51sBjWTk95uT-fO-fEnUVLF+qyt6eXuamKR7t364g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, Álvaro!
On Wed, Aug 6, 2025 at 6:01 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Apr-29, Alexander Korotkov wrote:
>
> > > 11) WaitLSNProcInfo / WaitLSNState
> > >
> > > Does this need to be exposed in xlogwait.h? These structs seem private
> > > to xlogwait.c, so maybe declare it there?
> >
> > Hmm, I don't remember why I moved them to xlogwait.h. OK, moved them
> > back to xlogwait.c.
>
> This change made the code no longer compile, because
> WaitLSNState->minWaitedLSN is used in xlogrecovery.c which no longer has
> access to the field definition. A rebased version with that change
> reverted is attached.
Thank you! The rebased version looks correct for me.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-08-08 06:57:36 | vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ? |
| Previous Message | Jelte Fennema-Nio | 2025-08-08 06:44:30 | Re: BackendKeyData is mandatory? |