| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org, Dave Cramer <davecramer(at)gmail(dot)com> |
| Subject: | Re: BackendKeyData is mandatory? |
| Date: | 2025-08-08 06:44:30 |
| Message-ID: | CAGECzQSs8vTitmdhKv046mGxK2YH+Vdh4qGkbSfEU1mxfxh5QA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 8 Aug 2025 at 00:03, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> That was not necessary for handleSyncLoss() to work, or for any other
> errors. If an error has occurred, PQgetResult() returns an error result,
> which is handled here.
You're right. I think I simply forgot to remove that in v3 (it was
necessary for v2). I'd say let's remove that check and keep the error
path closer to the behavior in other places.
Feel free to tweak/remove the copy-pasted comments as you see fit.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2025-08-08 06:54:18 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | shveta malik | 2025-08-08 06:34:00 | Re: Conflict detection for update_deleted in logical replication |