| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Jobin Augustine <jobin(dot)augustine(at)percona(dot)com> |
| Cc: | Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: test: avoid redundant standby catchup in 049_wait_for_lsn |
| Date: | 2026-11-13 22:25:32 |
| Message-ID: | CAPpHfdsc75bkcCbfNX0wi+B_8udq8=9Z+_=TB3D8Ke1bXyPnmQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Thu, Oct 1, 2026 at 8:43 AM Jobin Augustine
<jobin(dot)augustine(at)percona(dot)com> wrote:
>> Thanks. I had a general idea via your description and I'd like to know more about the use case. Please share it if you are ok with that.
>
> I am more than happy to share. The Rust program is pushed to my git repo and path : https://github.com/jobinau/pgscripts/tree/main/patroni/connection/waitforlsn
> There is a "repro" subdirectory with a file with instructions : REPRODUCE_WITH_WAITFORLSN.md please follow that for quick reproduction.
> Basically the program has a function `normalize_insert_lsn`which implements the client side fix. But passing a parameter `--raw-insert-lsn` to the program disables this client side manipulation.
Thanks to Xuneng for investigation, and thanks to Jobin for the
additional report.
I actually don't like idea of new pg_current_wal_insert_end_lsn()
function for the following reasons:
1) We should fix this for PG 19. But it's RC already, we should avoid
catversion bump if possible.
2) There is probability that users would still use
pg_current_wal_insert_lsn() and hit to this problem.
3) Additional compexity.
I suggest that WAIT FOR LSN can normalize the LSN to be waited on its
side. There is no point one should wait for the LSN inside the page
header. The attached patch implements that. Optinions?
------
Regards,
Alexander Korotkov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Don-t-make-WAIT-FOR-LSN-depend-on-WAL-written-aft.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-11-13 23:11:49 | Re: Let's drop support for named POSIX semaphores |
| Previous Message | surya poondla | 2026-11-13 22:20:55 | Re: pg_basebackup: check timeline history file write failures in ReceiveXlogStream() |