Re: jsonpath

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Subject: Re: jsonpath
Date: 2019-03-02 05:15:33
Message-ID: CAPpHfdsW924B1eYLqgXE0SkH0ym2Zk32CqPwUu_CH65Gk_onrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Fri, Mar 1, 2019 at 3:36 AM Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> wrote:
>
> Attached 34th version of the patches.
>
> 1. Partial jsonpath support:
> - Fixed copying of jsonb with vars jsonb_path_query() into SRF context
> - Fixed error message for jsonpath vars
> - Fixed file-level comment in jsonpath.c
>
> 2. Suppression of numeric errors:
> Now error handling is done without PG_TRY/PG_CATCH using a bunch of internal
> numeric functions with 'bool *error' flag.

Revised patches 1 and 2 are attached. Changes are following

* Small refactoring, comments adjustment and function renaming. In
particular, I've removed "recursive" prefix from function names,
because it actually not that informative assuming header comment
explains that the whole jsonpath executor is recursive. Also, I made
"Unwrap" suffix more clear. Not it's distinguished what is unwrapped
target (UnwrapTarget) or result (UnwrapResult). Also, now it's clear
that function doesn't always unwraps but has an option to do so
(OptUnwrap).
* Some more cases are covered by regression tests.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0001-Partial-implementation-of-SQL-JSON-path-language-v35.patch application/octet-stream 264.3 KB
0002-Suppression-of-numeric-errors-in-jsonpath-v35.patch application/octet-stream 24.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-03-02 07:01:50 Re: pg_dump multi VALUES INSERT
Previous Message Shawn Debnath 2019-03-02 05:05:32 Re: Refactoring the checkpointer's fsync request queue