| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(at)vondra(dot)me>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Get rid of WALBufMappingLock |
| Date: | 2025-07-06 22:48:06 |
| Message-ID: | CAPpHfdsLiQ22_Fcjjw7_9sEk+E4bVEjnLhbyPCzTQr1KuLcQYw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 5, 2025 at 7:16 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
>
> On Mon, Mar 31, 2025 at 09:18:30PM +0300, Alexander Korotkov wrote:
> > I'm going to push the first patch ("nowalbuf") if no objections.
>
> I completed a post-commit review of this patch. I think the patch is correct.
Great. I'm glad to hear that.
> I found some of the variable names and comments challenging, so I made the
> attached local edits in the course of the review. I don't know whether my
> choices are better or just tailored to my biases. If someone thinks this
> would improve the tree, I can polish this and commit it. Absent that,
> consider these notes to myself and to other post-commit reviewers.
I took a look to these edits. They look good to me.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-07-07 00:18:24 | Re: Instability of pg_walsummary/002_blocks.pl due to timing |
| Previous Message | Hannu Krosing | 2025-07-06 21:52:31 | Re: pgbench - adding pl/pgsql versions of tests |