| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(at)vondra(dot)me>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Get rid of WALBufMappingLock |
| Date: | 2025-07-05 04:15:59 |
| Message-ID: | 20250705041559.45.nmisch@google.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 31, 2025 at 09:18:30PM +0300, Alexander Korotkov wrote:
> I'm going to push the first patch ("nowalbuf") if no objections.
I completed a post-commit review of this patch. I think the patch is correct.
I found some of the variable names and comments challenging, so I made the
attached local edits in the course of the review. I don't know whether my
choices are better or just tailored to my biases. If someone thinks this
would improve the tree, I can polish this and commit it. Absent that,
consider these notes to myself and to other post-commit reviewers.
| Attachment | Content-Type | Size |
|---|---|---|
| AdvanceXLInsertBuffer-code-review-v0.patch | text/plain | 16.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-07-05 05:26:19 | Re: [PATCH] Allow parallelism for plpgsql return expression after commit 556f7b7 |
| Previous Message | jian he | 2025-07-05 03:35:28 | Re: array_random |