Re: Copy-pasto in comment in ExecAppendAsyncReset

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Copy-pasto in comment in ExecAppendAsyncReset
Date: 2026-11-03 13:31:03
Message-ID: CAPmGK17zpzNKzES5SuQzubrErkJow9rzM2TwFcHxJUm+E1Q2wA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 3, 2026 at 11:51 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > <fix-comments.patch>
>
> The fix looks good to me.
>
> Should we also update the header comment of ExecAppendAsyncEventWait since it only says “wait or poll” without explaining when to wait and when to poll? Something like:
> ```
> /*
> * ExecAppendAsyncEventWait
> *
> * Wait or poll for file descriptor events and fire callbacks.
> * If as_syncdone is true, wait until at least one event occurs;
> * otherwise, poll without waiting so synchronous execution can proceed.
> */
> ```

That would be an improvement rather than a fix, so I'd like to leave
it for another (master-only) patch.

Thanks for looking!

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2026-11-03 13:34:29 Make Append subplans async capable in more cases
Previous Message Daniel Gustafsson 2026-11-03 13:30:02 Re: [PATCH] Keep git-external-diff usage text from executing