| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Copy-pasto in comment in ExecAppendAsyncReset |
| Date: | 2026-11-03 02:51:21 |
| Message-ID: | 68B0F5C5-A147-4A0B-A63A-5A415E62632F@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 3, 2026, at 10:26, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> Hi,
>
> While working on the Asynchronous-MergeAppend patch, I noticed
> $SUBJECT: "Wait or poll for async events." for the call to
> ExecAppendAsyncEventWait. We call it with node->as_syncdone=true,
> which makes it wait until at least one event occurs, as commented
> above, so it never polls. Attached is a small patch for fixing that
> comment.
>
> Best regards,
> Etsuro Fujita
> <fix-comments.patch>
The fix looks good to me.
Should we also update the header comment of ExecAppendAsyncEventWait since it only says “wait or poll” without explaining when to wait and when to poll? Something like:
```
/*
* ExecAppendAsyncEventWait
*
* Wait or poll for file descriptor events and fire callbacks.
* If as_syncdone is true, wait until at least one event occurs;
* otherwise, poll without waiting so synchronous execution can proceed.
*/
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou | 2026-11-03 03:10:48 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Jonathan S. Katz | 2026-11-03 02:33:11 | Re: PostgreSQL 19 GA press release draft |