Re: Incorrect file reference in comment in procarray.c

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect file reference in comment in procarray.c
Date: 2023-11-13 10:20:43
Message-ID: CAPmGK17y=+buvMNraMYve9z1DhLWxXc+O9OOijJpho86VLfANA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 3, 2023 at 6:53 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
> >
> > No objections to the patch, the change is correct. However, with git grep and
> > ctags and other ways of discovery I wonder if we're not better off avoiding
> > such references to filenames which are prone to going stale (and do from time
> > to time).
>
> Agreed. As XidInMVCCSnapshot() is an extern function, such a tool
> would allow the reader to easily find the source file that contains
> the definition of that function.

Pushed, and back-patched, like that.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-11-13 10:21:43 Re: partitioning and identity column
Previous Message Peter Eisentraut 2023-11-13 10:09:28 Re: serial and partitioned table