From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Incorrect file reference in comment in procarray.c |
Date: | 2023-11-03 09:53:57 |
Message-ID: | CAPmGK17xBNsstecZ91c4=0v83dWRs+ip2_qjE_rUQU2LBDx=HQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
>
> No objections to the patch, the change is correct. However, with git grep and
> ctags and other ways of discovery I wonder if we're not better off avoiding
> such references to filenames which are prone to going stale (and do from time
> to time).
Agreed. As XidInMVCCSnapshot() is an extern function, such a tool
would allow the reader to easily find the source file that contains
the definition of that function.
Thanks for the comment!
Best regards,
Etsuro Fujita
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2023-11-03 10:11:50 | Re: Pre-proposal: unicode normalized text |
Previous Message | Jelte Fennema-Nio | 2023-11-03 09:22:35 | Re: Report search_path value back to the client. |