Re: Further cleanup related to statistics import support in postgres_fdw

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Further cleanup related to statistics import support in postgres_fdw
Date: 2026-08-22 10:26:15
Message-ID: CAPmGK17oMNFNK9TbK_30G22a277FKFqVPPmWqnEVdxH3+60k5Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Bharath,

On Sat, Aug 22, 2026 at 5:40 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Fri, Aug 21, 2026 at 3:04 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > Attached is an updated version of the patch.
>
> The changes look good to me. pgindent wasn't happy about one thing
> [1], make check-world is fine (except a known issue in postgres_fdw
> being discussed in [2]).

Thanks for looking! I fixed the indentation. Attached is an updated
patch for that.

(As for the regression test issue, I couldn't reproduce it in my
environment, so I didn't do anything about it. I want to leave it to
Alexander. I think he is probably busy with other stuff right now,
though.)

> I think this also needs to be backpatched (unless others think
> otherwise) because this code is new in PG19 and it's better to keep
> the version diff to a minimum.

Agreed. I will push/backpatch the patch if no objections from others.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgres-fdw-stats-import-cleanup-v3.patch application/octet-stream 11.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2026-08-22 10:34:11 Re: GIN page deletion and page recycling bugs
Previous Message 达劳里亚斯 2026-08-22 10:21:27 Re: pg_upgrade --copy-file-range fails with EINVAL on Linux 4.19