Re: Further cleanup related to statistics import support in postgres_fdw

Hi,

On Fri, Aug 21, 2026 at 3:04 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> Attached is an updated version of the patch.

The changes look good to me. pgindent wasn't happy about one thing
[1], make check-world is fine (except a known issue in postgres_fdw
being discussed in [2]).

I think this also needs to be backpatched (unless others think
otherwise) because this code is new in PG19 and it's better to keep
the version diff to a minimum.

[1]
dev-dsk-rupiredd-2b-b0ec5a8e % git diff
diff --git a/contrib/postgres_fdw/postgres_fdw.c
b/contrib/postgres_fdw/postgres_fdw.c
index 07a80bf9365..bbadd58d893 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -393,7 +393,7 @@ typedef struct
{
AttrNumber local_attnum; /* attribute number of local column */
char *local_attname; /* attribute name of local column */
- char *remote_attname; /* attribute name of remote column */
+ char *remote_attname; /* attribute name of remote column */
int res_index; /* index of
row in attribute stats result */
} RemoteAttributeMapping;

[2] https://www.postgresql.org/message-id/CALj2ACVd3uEt9MpNT1zGYjOOXTFLB5qdNcr50YXyEAG%3DGo9TKQ%40mail.gmail.com

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com