| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, "gkokolatos(at)pm(dot)me" <gkokolatos(at)pm(dot)me>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Allow batched insert during cross-partition updates |
| Date: | 2022-12-20 10:19:51 |
| Message-ID: | CAPmGK17DR2C+tPBYg1oAne84FM1njYW+jGOfY4TQWaqY25mUMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit-san,
On Wed, Dec 14, 2022 at 10:29 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Dec 14, 2022 at 6:45 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > One thing I noticed is this bit:
> >
> > -- Clean up
> > -DROP TABLE batch_table, batch_cp_upd_test, batch_table_p0,
> > batch_table_p1 CASCADE;
> > +DROP TABLE batch_table, batch_table_p0, batch_table_p1,
> > batch_cp_upd_test, cmdlog CASCADE;
> >
> > This would be nitpicking, but this as-proposed will not remove remote
> > tables created for foreign-table partitions of the partitioned table
> > ‘batch_cp_upd_test’. So I modified this a bit further to remove them
> > as well. Also, I split this into two, for readability. Another thing
> > is a typo in a test-case comment: s/a single INSERTs/a single INSERT/.
> > I fixed it as well. Other than that, the patch looks good to me.
> > Attached is an updated patch. If there are no objections, I will
> > commit the patch.
>
> LGTM.
Cool! Pushed.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-12-20 10:49:42 | Re: Force streaming every change in logical decoding |
| Previous Message | houzj.fnst@fujitsu.com | 2022-12-20 10:16:23 | RE: Perform streaming logical transactions by background workers and parallel apply |