| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-08-11 17:30:51 |
| Message-ID: | CADkLM=ezuspTk3VD-2EM6XtFP-Dfz7cJKtnbn0cB6gocsAgu1g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> There is one thing I'd like to change for v19: the name of the option
> for this feature. We named it restore_stats because it used the
> pg_restore_*() functions [1], but it doesn't use them anymore; it uses
> import_*_statistics() instead, so I think we should rename it to
> import_stats if not too late. I think it also matches the names of
> functions added to postgres_fdw.c like import_fetched_statistics().
> What do you think?
>
I think it's worth a quick patch...
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Rename-postgres_fdw-option-restore_stats-to-impor.patch | text/x-patch | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Nathan Bossart | 2026-08-11 17:25:01 | CREATE INDEX vs. TOAST table stats |