| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com> |
| Subject: | Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT |
| Date: | 2022-05-30 06:27:42 |
| Message-ID: | CAPmGK16iznMWWEof5fk7XMTuRoASe4KqKsW6oDHdfUbs-hD=ng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit-san,
On Fri, May 27, 2022 at 9:22 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > Attached is a patch for that.
> I think we should also rewrite the description to match the CREATE
> TABLE's text, as in the attached updated patch.
Actually, I thought the description would be OK as-is, because it says
“See the similar form of CREATE TABLE for more details”, but I agree
with you; it’s much better to also rewrite the description as you
suggest.
I’ll commit the patch unless Robert wants to.
Thanks for the review and patch!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-05-30 06:52:29 | Re: Support logical replication of DDLs |
| Previous Message | Masahiko Sawada | 2022-05-30 05:42:56 | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |