| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Asynchronous MergeAppend |
| Date: | 2026-04-07 10:25:41 |
| Message-ID: | CAPmGK16dNmOhFpSu1nSh7699PXViTJNp12enfUmiBn95gRVUdQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 7, 2026 at 9:25 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> Thank you for your feedback. I would say that this patch is here for
> quite long, and it's pretty straightforward. It passed many rounds of
> review by Matheus Alcantara. I've done a lot of minor cleanups and
> improvements, and reorganized changes into multiple patches. The only
> major change I did is actually a simplification which come from the
> fact that only initial heap filling is effectively async [1]. Today
> Matheus gave a feedback on my changes.
I think Matheus did a good job, but he said "I still don't have too
much experience with the executor code but I hope that I can help with
something.", and IIUC, his reviews were mostly about code
cleanup/deduplication, so ISTM that the patch hadn't been reviewed
that extensively, despite its complexity. That was actually one of
the reasons why I lowered the priority of the patch.
> Surely, I wouldn't commit this patch without giving you a chance to
> review. We can postpone it till early PG20 development cycle. But if
> you find it possible to take a look at this patch during Apr 7, let me
> know.
Sorry, I don't have time for that. I will defer to your judgment, too.
Thank all of you for working on this important feature, anyway!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2026-04-07 10:26:23 | Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication |
| Previous Message | Etsuro Fujita | 2026-04-07 10:09:46 | Re: Import Statistics in postgres_fdw before resorting to sampling. |